Skip to content

fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link#197

Merged
shazron merged 2 commits intomasterfrom
story/ACNA-3397
Dec 12, 2024
Merged

fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link#197
shazron merged 2 commits intomasterfrom
story/ACNA-3397

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Dec 10, 2024 •
edited
Loading

Part of a fix in aio-cli-plugin-app. See adobe/aio-cli-plugin-app#823
Blocks adobe/aio-cli-plugin-app#824

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb53455) to head (42b6597).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1328      1325    -3     
  Branches       350       345    -5     
=========================================
- Hits          1328      1325    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron mentioned this pull request Dec 10, 2024
Closed
@shazron shazron mentioned this pull request Dec 10, 2024
Merged
14 tasks
purplecabbage
purplecabbage approved these changes Dec 11, 2024
View reviewed changes
@shazron shazron merged commit 827baba into master Dec 12, 2024
@shazron shazron deleted the story/ACNA-3397 branch December 12, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purplecabbage purplecabbage purplecabbage approved these changes

@moritzraho moritzraho moritzraho approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shazron @purplecabbage @moritzraho @MichaelGoberling